Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve: walking system independent of server response #1087

Merged
merged 12 commits into from
Feb 1, 2025
Merged

Conversation

mehah
Copy link
Owner

@mehah mehah commented Jan 30, 2025

possible fix #918

@mehah mehah requested a review from nekiro January 30, 2025 01:11
@mehah mehah marked this pull request as draft January 30, 2025 01:17
@mehah mehah removed the request for review from nekiro January 30, 2025 01:17
@mehah mehah changed the title fix: mapView shaking when walking improve: server independent walking system Feb 1, 2025
@mehah mehah marked this pull request as ready for review February 1, 2025 02:12
@mehah mehah marked this pull request as draft February 1, 2025 02:56
@mehah mehah changed the title improve: server independent walking system improve: walking system 50% independent of server response. Feb 1, 2025
@mehah mehah changed the title improve: walking system 50% independent of server response. improve: walking system independent of server response Feb 1, 2025
@mehah mehah marked this pull request as ready for review February 1, 2025 20:32
Copy link

sonarqubecloud bot commented Feb 1, 2025

@mehah mehah merged commit 617d256 into main Feb 1, 2025
12 checks passed
@mehah mehah deleted the fix_mapview_shaking branch February 1, 2025 21:58
@jan7c6
Copy link

jan7c6 commented Feb 2, 2025

Hello, since this merge I am getting the following error when, for example, stepping into a teleport that moves the player back to the position it stepped into. Then, the player is not able to move anymore.

Unforunately i cannot run the windows-debug build (yet) so I cant look into it in detail. Also I'm not fluent in Tibia-Protocol ;) but maybe, with your experience, you can already see where the problem is.

If you need any further information, please let me know.

ERROR: no thing at pos:33234 32277 12, stackpos:1
at: [C++]: ?getMappedThing@ProtocolGame@@QEBA?AV?$shared_ptr@VThing@@@std@@AEBV $shared_ptr@VInputMessage@@@3@@Z

ERROR: ProtocolGame::parseCreatureMove: no creature found to move
at: [C++]: ?parseCreatureMove@ProtocolGame@@AEAAXAEBV?$shared_ptr@VInputMessage@@@std@@@Z

@mehah
Copy link
Owner Author

mehah commented Feb 2, 2025

@jan7c6

I am aware of these problems, I will correct them during the week.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MapView is shaking when walking
2 participants